[Dev] Add Playwright MCP for Local Development #4028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Results of upgrading playwright version to 1.52.0(and upgrading associated dev deps) Test Failures
Artifact download URL |
christian-byrne
added
the
New Browser Test Expectations
webfiltered
requested changes
May 30, 2025
There was a problem hiding this comment.
Nice! Good to go once criteria are met:
- #4029 is resolved
- This is rebased
- Expectations commit reverted
- Re-add label if still failing CI, and we can look again
christian-byrne
force-pushed
the
add-claude-command-2
branch
from
5867aad to
8564e34
Compare
christian-byrne
force-pushed
the
add-claude-command-2
branch
from
8564e34 to
2f0bf89
Compare
|
The flaky tests have been resolved by #4031 and this has been rebased. Thee three failing tests detailed in above comment still occur, but are simply due to bumping to new playwright version. 2/3 are <10 pixel differences and 1 is due to font changing in node title within litegraph properties panel. Going to re-add the label to update test expectations. |
christian-byrne
added
New Browser Test Expectations
webfiltered
added a commit
that referenced
this pull request
Jun 1, 2025
This reverts commit 86a7dd0.
webfiltered
added a commit
that referenced
this pull request
Jun 1, 2025
This reverts commit 86a7dd0.
webfiltered
added a commit
that referenced
this pull request
Jun 1, 2025
webfiltered
added a commit
that referenced
this pull request
Jun 1, 2025
lordTyrion
pushed a commit
to playbook3d/ComfyUI_frontend
that referenced
this pull request
Jul 2, 2025
Co-authored-by: github-actions <[email protected]>
lordTyrion
pushed a commit
to playbook3d/ComfyUI_frontend
that referenced
this pull request
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds all setup necessary to use Playwright MCP with Claude Code. Run
npm installthen simply tell coding assistant to navigate to localhost:5173 and take a screenshot in order to verify some visual changes or iterate on browser tests. Example:┆Issue is synchronized with this Notion page by Unito