[TS] Fix ts-strict errors in Vue components (Part 2) #3123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| key: item.id || item.name | ||
| })) as (components['schemas']['Node'] & { key: string })[] | ||
| ) | ||
There was a problem hiding this comment.
For this, since we only need the key for the purpose of rendering, maybe we can just generate a unique key if the name doesn't exist
There was a problem hiding this comment.
I am going to leave this change to you (in a separate PR) as it involves with larger scale logic change
Co-authored-by: Christian Byrne <[email protected]>
christian-byrne
added a commit
that referenced
this pull request
May 20, 2025
Co-authored-by: Christian Byrne <[email protected]>
christian-byrne
added a commit
that referenced
this pull request
Sep 19, 2025
Add optional chaining to nodeDef.description access to prevent "Cannot read properties of undefined (reading 'description')" error when node type is not found in nodeDefStore. Follows same pattern as previous fixes in commits: - 290bf52 (Fix frontend node tooltip error #911) - e8997a7 (Fix ts-strict errors in Vue components Part 2 #3123) Fixes CLOUD-FRONTEND-STAGING-1B
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #3120
This PR is part of the bigger effort to enable strict mode in tsconfig.
┆Issue is synchronized with this Notion page by Unito