Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playwright concurrency - multi-user mode #1400

Merged
merged 4 commits into from
Nov 2, 2024
Merged

Conversation

webfiltered
Copy link
Collaborator

@webfiltered webfiltered commented Nov 2, 2024

Requires: Comfy-Org/ComfyUI_devtools#3

Changes testing mode to per-file concurrency - each file runs its contents sequentially. Some tests explicitly rely on the state from the previous test.

The ComfyUI test instance must have --multi-user set, or tests will fail randomly (polluted state).

@huchenlei
Copy link
Member

Hmmm, Duplicated Username?

@webfiltered
Copy link
Collaborator Author

Comfy-Org/ComfyUI_devtools#3 - probably should have linked the PRs.

@webfiltered
Copy link
Collaborator Author

Looks like it's not getting the --multi-user on the command line:

✓ built in 7.96s
Run python main.py --cpu  &
  python main.py --cpu  &
  wait-for-it --service 127.0.0.1:8188 -t 600
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@huchenlei huchenlei merged commit caa3ac2 into main Nov 2, 2024
9 checks passed
@huchenlei huchenlei deleted the playwright-parrallelism branch November 2, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants