Fix group node copy paste #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
requested changes
Oct 2, 2024
|
Can you do a rebase instead of merge? Currently it captures many changes not belonging to this PR. |
huchenlei
force-pushed
the
groupnode/copy-paste
branch
from
3dad214
to
60c14d6
Compare
huchenlei
approved these changes
Oct 2, 2024
Sorry - Thanks for doing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues with group node copy/paste:
Group nodes unregister themselves when
app.cleanis called (pressing "Clear Workflow", loading a blank workflow), preventing copy-pasting between workflows afterwards.Replicate: create group node, "Workflow" -> "New", try to copy/paste group node between workflows.
Fix: Remove unregistration. It no longer makes sense when multiple workflows can be open simultaneously.
Group nodes are added to
app.graph.extraduring construction but not after copy/pasting.Replicate: create group node, paste to another workflow, reload or save/load that workflow.
Fix: Add to
app.graph.extraduring node creation callback.