Enable ts-strict for uploadImage.ts (#1280)

Comfy-Org · Oct 23, 2024 · 5db757a · 5db757a
1 parent 59c03d2
commit 5db757a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/extensions/core/uploadImage.ts b/src/extensions/core/uploadImage.ts
@@ -1,12 +1,11 @@
-// @ts-strict-ignore
 import { app } from '../../scripts/app'
 import { ComfyNodeDef } from '@/types/apiTypes'
 
 // Adds an upload button to the nodes
 
 app.registerExtension({
   name: 'Comfy.UploadImage',
-  async beforeRegisterNodeDef(nodeType, nodeData: ComfyNodeDef, app) {
+  beforeRegisterNodeDef(nodeType, nodeData: ComfyNodeDef) {
     if (nodeData?.input?.required?.image?.[1]?.image_upload === true) {
       nodeData.input.required.upload = ['IMAGEUPLOAD']
     }

diff --git a/src/types/comfy.d.ts b/src/types/comfy.d.ts
@@ -59,7 +59,7 @@ export interface ComfyExtension {
    * @param app The ComfyUI app instance
    */
   addCustomNodeDefs?(
-    defs: Record<string, ComfyObjectInfo>,
+    defs: Record<string, ComfyNodeDef>,
     app: ComfyApp
   ): Promise<void> | void
   /**
@@ -76,7 +76,7 @@ export interface ComfyExtension {
    */
   beforeRegisterNodeDef?(
     nodeType: typeof LGraphNode,
-    nodeData: ComfyObjectInfo,
+    nodeData: ComfyNodeDef,
     app: ComfyApp
   ): Promise<void> | void
 
@@ -114,6 +114,9 @@ export interface ComfyExtension {
   [key: string]: any
 }
 
+/**
+ * @deprecated Use ComfyNodeDef instead
+ */
 export type ComfyObjectInfo = {
   name: string
   display_name?: string