N°4789 - Parse datamodel module.xxx.php files instead of interpreting them #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquetiez
requested changes
Sep 9, 2025
| $sExpr; | ||
| PHP; | ||
| try{ | ||
| $aNodes = ModuleFileParser::GetInstance()->ParsePhpCode($sPhpContent); |
There was a problem hiding this comment.
I thought this class is consumed by ModuleFileParser... not the other way around!
… them - refactoring all in a dedicated service first
…dle ModuleInstallerAPI methods calls during setup
…p redondant evaluators
…ove ModuleFileParser internal logic into ModuleFileReader
odain-cbd
force-pushed
the
feature/4789-nikicfork
branch
from
cf28d40 to
9436a02
Compare
odain-cbd
added a commit
that referenced
this pull request
Sep 16, 2025
… them (#746) - namespacing ModuleFileReader classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relies on a fork from nikic/PHP-Parser
nikic/PHP-Parser#1107
The idea is to enhance how module configuration are read. It would have been nice to propose another format as well (ie json). but this is another story...