N°7348 - Enable to param maximum depth of impact analysis in function Ticket::UpdateImpactedItems

[accognet]

In this kind of delta

we want to limit depth of impact analysis to 1 or 2. It's actually hard coded to 10.

[Hipska]

How and where would that be configured then?

[accognet]

Directly in the delta on the function call

[Molkobain]

Accepted during support PRs review.
A migration check has been done, as this change will break existing overloads of this method.

During functional review, we will discuss whether it's ok or we should rather use a config param.

[Molkobain]

Functional review: Accepted for iTop 3.3. Not 3.2 as there are changes requested and we are too close to the code freeze.

Changes to do:

• Rather than changing the prototype of the existing method, add a new _Ticket::GetImpactAnalysisMaxDepth().
  • It will avoid breaking existing overloads of the current method
  • It will make customization more clear for support when it is juste about changing the depth and not reworking the whole method
• Add unit tests based on the test cases reworked by Romain / Eric lately.
  • For the unit tests, we might have to add a config param on the module so it can be changed in the test. We'll have to see if we can find a way to avoid that.

[Molkobain]

Previous message means that once this PR is accepted during "Support PRs review" or "Technical review", it can be merged without going to "Functional review" again