Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Collection.amb. #31

Merged
merged 1 commit into from
May 16, 2020
Merged

Adds Collection.amb. #31

merged 1 commit into from
May 16, 2020

Conversation

jasdev
Copy link
Member

@jasdev jasdev commented May 11, 2020

@klundberg’s question in #reactive yesterday reminded me that we should probably add a Collection overlay for amb.

@klundberg’s question in #reactive yesterday reminded me that we should probably add a `Collection` overlay for `amb`.
@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #31 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   97.42%   97.48%   +0.05%     
==========================================
  Files          40       40              
  Lines        2332     2387      +55     
==========================================
+ Hits         2272     2327      +55     
  Misses         60       60              
Impacted Files Coverage Δ
Sources/Operators/Amb.swift 100.00% <100.00%> (ø)
Tests/AmbTests.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60f5815...40b489f. Read the comment docs.

Copy link
Member

@freak4pc freak4pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@freak4pc freak4pc merged commit 485d80e into CombineCommunity:master May 16, 2020
@jasdev jasdev deleted the amb-collection branch May 16, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants