Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ammo Housekeeping #3225

Merged
merged 11 commits into from
Jun 30, 2024
Merged

Ammo Housekeeping #3225

merged 11 commits into from
Jun 30, 2024

Conversation

N7Huntsman
Copy link
Contributor

@N7Huntsman N7Huntsman commented Jun 30, 2024

Additions

  • Airburst grenade generic ammo.

Changes

  • Housekeeping changes to keep consistent with projectile sheet.

References

All the various housekeeping changes from #3170, minus the balance changes from the new formula.

Reasoning

Not finished evaluating/updating the projectile sheet and don't want to hold up these changes from #3170 from the initial release. Other changes can be PR'd later from the original branch.

Alternatives

  • Could leave as is.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners June 30, 2024 22:03
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9735249738.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Jun 30, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9735335705.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9735337980.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9735391167.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9735464939.zip

Copy link
Contributor

@Airomeda Airomeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for a merge 👍

@N7Huntsman N7Huntsman merged commit c878437 into Development Jun 30, 2024
2 checks passed
@N7Huntsman N7Huntsman deleted the Ammo-Misc branch June 30, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants