Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packageparser): remove support for invalid exports shapes #336

Merged
merged 8 commits into from
Nov 24, 2024
Merged

Conversation

Comandeer
Copy link
Owner

Closes #335.
Closes #308.

@Comandeer Comandeer changed the title fix(packageParser): remove support for invalid exports shapes fix(packageparser): remove support for invalid exports shapes Nov 24, 2024
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 97.63780% with 3 lines in your changes missing coverage. Please review.

Project coverage is 99.44%. Comparing base (c386eb1) to head (1297758).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/packageParser/PackageJSON.ts 95.83% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
- Coverage   99.70%   99.44%   -0.27%     
==========================================
  Files          13       14       +1     
  Lines        1025     1075      +50     
  Branches       96      102       +6     
==========================================
+ Hits         1022     1069      +47     
- Misses          2        5       +3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Comandeer Comandeer merged commit 64c828b into main Nov 24, 2024
7 of 10 checks passed
@Comandeer Comandeer deleted the t/308 branch November 24, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for the invalid exports shapes Refactor the codebase to enable TS strict mode
1 participant