Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to set title card dimensions #314

Closed
CollinHeist opened this issue Mar 8, 2023 · 1 comment · Fixed by #323
Closed

Add option to set title card dimensions #314

CollinHeist opened this issue Mar 8, 2023 · 1 comment · Fixed by #323
Assignees
@CollinHeist
Labels
enhancement New feature or request needs-merged Issue has been resolved on a development branch

Comments

@CollinHeist
Copy link
Owner

As suggested on the Discord:

Cards are written and created using 3200x1800 pixels, but for users who want to reduce their file sizes this should be adjustable.

Best implementation would likely be a global options option, like so:

options:
  card_dimensions: {width}x{height}

In the web interface this should be in the Settings page alongside card extension.
@CollinHeist CollinHeist added the enhancement New feature or request label Mar 8, 2023
@CollinHeist CollinHeist self-assigned this Mar 8, 2023
CollinHeist added a commit that referenced this issue Apr 7, 2023
@CollinHeist
Optionally adjust title card dimensions
9e1d8da 
- Parse global "card_dimensions" YAML option to adjust the output dimensions of all title cards
- Currently only built in card types apply this resizing
- Implement #314

- Also change the default image source priority to tmdb, plex, emby, jellyfin
CollinHeist added a commit that referenced this issue Apr 9, 2023
@CollinHeist
Add card dimensions to Preference pydantic models
73a20f7 
- Adjust preference updating endpoint to utilize optional JSON encoding instead of individual Form components (#311 part of #314)
- Resize preview card type on mobile
- Make settings form stackable on mobile
- Add form validation to settings form
@CollinHeist CollinHeist added the needs-merged Issue has been resolved on a development branch label Apr 9, 2023
@CollinHeist
Copy link
Owner Author

These changes will also have to be made to the user-created card types.

CollinHeist added a commit to CollinHeist/TitleCardMaker-CardTypes that referenced this issue Apr 9, 2023
@CollinHeist
Optionally adjust title card dimensions
66fc2eb 
Implements CollinHeist/TitleCardMaker#314 for user card types
@CollinHeist CollinHeist mentioned this issue Apr 10, 2023
Merged
CollinHeist added a commit that referenced this issue Apr 11, 2023
@CollinHeist
Add card dimensions to settings page
1fc0ae2 
- #314 implemented in #311
- Add card width/height to the title card section of the settings page
- Increase size of preview title card
- Turn some title attributes into data tooltips
- Move CSS support feature icons into HTML color classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CollinHeist CollinHeist

Labels
enhancement New feature or request needs-merged Issue has been resolved on a development branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optionally adjust output card dimensions, various other fixes and changes CollinHeist/TitleCardMaker
1 participant
@CollinHeist