Fix Chinese Search Bug #245
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rachel030219
requested changes
Jul 17, 2024
add separator to search plugins
|
Commits have been reset. I am very sorry for the additional workload before. |
7emotions
commented
Jul 18, 2024
| # Ignored samples with excessively long names | ||
| if len(filename) > 150: | ||
| continue | ||
|
|
There was a problem hiding this comment.
The reason for the modification is that an error was encountered while writing files on account of long filename. This is not relevant to the main work of this PR.
|
Additionally, in order to implement keyword search, the source file of mkdocs needs to be modified to use jieba for Chinese word segmentation. However, such modification is not in the repository code, and I want to know whether this solution is acceptable. Related changes can be found here.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #138 , at the moment searching with full university name does not work.
Bug Reproduce
As shown in the following figures, NJUST, for example, was included in the dataset, but no corresponding results were found in the search box.
Solution Effect
As shown in the following figure, NJUST, including its multiple campuses, has been correctly displayed.
In addition, searching suggestions are provided while typing.