Do not include js files in TS compilation #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problem: in compilation tsc removes blank lines from the file this causes problem in debugging and mapping with IDEs microsoft/TypeScript#843 Signed-off-by: Pranam Lashkari <[email protected]> Change-Id: Ie2df89ba09597a34aca9221bf082b1f2df3c7d07
dennisfrancis
approved these changes
Jun 2, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pranam Lashkari [email protected]
Change-Id: Ie2df89ba09597a34aca9221bf082b1f2df3c7d07
Summary
problem:
in compilation tsc removes blank lines from the file
this causes problem in debugging and mapping with IDEs
microsoft/TypeScript#843
Checklist
make checkmake runand manually verified that everything looks okay