-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore: ๐ Reduce distributed lock duration by separating domain logic #238
Merged
psychology50
merged 22 commits into
dev
from
fix/separate-chatroom-join-logic-for-reducing-lock-process-time
Feb 7, 2025
Merged
Ignore: ๐ Reduce distributed lock duration by separating domain logic #238
psychology50
merged 22 commits into
dev
from
fix/separate-chatroom-join-logic-for-reducing-lock-process-time
Feb 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
์์ ์ด์
#237
The current chat room join implementation had an issue where distributed locks were held for too long, as they included both business validation and data retrieval for responses.
This refactoring aims to:
์์ ์ฌํญ
Extracted core join logic into
ChatMemberJoinOperation
Optimized
ChatMemberJoinService
Added comprehensive test coverage
๋ฆฌ๋ทฐ์ด๊ฐ ์ค์ ์ ์ผ๋ก ํ์ธํด์ผ ํ๋ ๋ถ๋ถ
I know, I know. I get that it was inappropriate to suddenly carry out such a large-scale change. But I've never liked the fact that the Aggregate Root references the User object in another ChatMember as an entity. This time, I had to change it to a value reference because otherwise, it could cause a serious delay in chat room joins.
๋ฐ๊ฒฌํ ์ด์