Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore: ๐Ÿ› Remove Prefix During S3 Image Validation & Fix Infinite Invitation Messages #234

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

psychology50
Copy link
Member

์ž‘์—… ์ด์œ 

  • We found an issue where the client fails to update their chat room information when the chat room's profile image remains unchanged.
  • The socket server was sending a join message perpetually. Since this was an urgent issue, I fixed it in this PR.

์ž‘์—… ์‚ฌํ•ญ

  • During S3 image validation, the service now removes the prefix from the profile URL.
  • The root cause of the infinite message loop was the handling of the success response after sending a message. When the client sent a message, the process confirming the successful transmission triggered an error as the system attempted to publish the message. This led to an infinite consumption loop in the message queue (MQ). To resolve this, I modified the logic to properly handle cases where the sender name is null, preventing the error from occurring.

๋ฆฌ๋ทฐ์–ด๊ฐ€ ์ค‘์ ์ ์œผ๋กœ ํ™•์ธํ•ด์•ผ ํ•˜๋Š” ๋ถ€๋ถ„

  • none

๋ฐœ๊ฒฌํ•œ ์ด์Šˆ

  • none

@psychology50 psychology50 added bug ๊ธด๊ธ‰ํ•˜๊ณ , ์ค‘์š”๋„๊ฐ€ ๋†’์€ ์ด์Šˆ fix ๊ธฐ๋Šฅ ์ˆ˜์ • labels Feb 3, 2025
@psychology50 psychology50 self-assigned this Feb 3, 2025
@psychology50 psychology50 merged commit 60ec395 into dev Feb 4, 2025
1 check passed
@psychology50 psychology50 deleted the fix/404-chat-room-profile-maintain-scenario branch February 4, 2025 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ๊ธด๊ธ‰ํ•˜๊ณ , ์ค‘์š”๋„๊ฐ€ ๋†’์€ ์ด์Šˆ fix ๊ธฐ๋Šฅ ์ˆ˜์ •
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant