Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore: ✨ Chat Room Admin Delegation API #231

Merged
merged 19 commits into from
Jan 24, 2025

Conversation

psychology50
Copy link
Member

작업 이유

  • The admin should be able to delegate their role to another chat member within the same chat room.

작업 사항

  • Implemented service and controller logic.
  • Added tests for the business logic.

리뷰어가 중점적으로 확인해야 하는 부분

Please carefully review potential conflict scenarios.
For instance, if the chat member who is about to be promoted to admin requests to leave the chat room, this could result in the chat room having no admin in the worst-case scenario. 😅

How to Handle This?
Do you have any good ideas for addressing this?
Feel free to share your thoughts!


발견한 이슈

  • none.

@psychology50 psychology50 added the enhancement New feature or request label Jan 24, 2025
@psychology50 psychology50 self-assigned this Jan 24, 2025
@psychology50 psychology50 merged commit 2c97f9b into dev Jan 24, 2025
1 check passed
@psychology50 psychology50 deleted the feat/PW-672-delegate-chat-admin branch January 24, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant