-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api: ✨ 소비내역 복수 삭제 API #119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychology50
requested changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
테스트가 실패한 상태긴 하지만, 현재 작업하신 부분까지 리뷰 남깁니다~
...way-domain/src/main/java/kr/co/pennyway/domain/domains/spending/service/SpendingService.java
Outdated
Show resolved
Hide resolved
...external-api/src/main/java/kr/co/pennyway/api/apis/ledger/controller/SpendingController.java
Show resolved
Hide resolved
...rnal-api/src/main/java/kr/co/pennyway/api/common/security/authorization/SpendingManager.java
Show resolved
Hide resolved
pennyway-app-external-api/src/main/java/kr/co/pennyway/api/apis/ledger/dto/SpendingIdsDto.java
Outdated
Show resolved
Hide resolved
.../test/java/kr/co/pennyway/api/apis/ledger/integration/SpendingControllerIntegrationTest.java
Outdated
Show resolved
Hide resolved
psychology50
reviewed
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
하나 확인이 필요한 게 있어서 커멘트 남깁니다!
다른 하나는 의견이 궁금해서 남겨요
...rnal-api/src/main/java/kr/co/pennyway/api/common/security/authorization/SpendingManager.java
Outdated
Show resolved
Hide resolved
...main/src/main/java/kr/co/pennyway/domain/domains/spending/repository/SpendingRepository.java
Outdated
Show resolved
Hide resolved
merge하고 불러주시면 바로 승인하겠습니다~ |
psychology50
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 이유
복수개의 소비내역을 삭제하는 API 필요.
작업 사항
API Spec
DELETE /v2/spendings
결과 응답
리뷰어가 중점적으로 확인해야 하는 부분
deleteAllById
사용이 적절한지?발견한 이슈
진작에

deleteAllById
를 사용하면 됐는데, 멍청하게 QueryDSL을 활용해서 직접 다 구현하다가 뒤늦게 깨닫는 멍청비용을 소모하였습니다.