Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api: ✨ 소비내역 복수 삭제 API #119

Merged
merged 17 commits into from
Jul 4, 2024
Merged

Conversation

asn6878
Copy link
Collaborator

@asn6878 asn6878 commented Jun 30, 2024

작업 이유

복수개의 소비내역을 삭제하는 API 필요.


작업 사항

API Spec

  • url : DELETE /v2/spendings
  • pre-condition : 사용자는 로그인 한 상태이고, 삭제하고자 하는 지출 내역들의 작성자여야 한다.

결과 응답

{
  "code" : "2000",
  "data" : { }
}

리뷰어가 중점적으로 확인해야 하는 부분

  • deleteAllById 사용이 적절한지?
  • 더 검증할 테스트 케이스가 있는지?
  • 요청 URL이 적절한지?

발견한 이슈

진작에 deleteAllById를 사용하면 됐는데, 멍청하게 QueryDSL을 활용해서 직접 다 구현하다가 뒤늦게 깨닫는 멍청비용을 소모하였습니다.
image

@asn6878 asn6878 added the enhancement New feature or request label Jun 30, 2024
@asn6878 asn6878 self-assigned this Jun 30, 2024
Copy link
Member

@psychology50 psychology50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트가 실패한 상태긴 하지만, 현재 작업하신 부분까지 리뷰 남깁니다~

@asn6878 asn6878 requested a review from psychology50 July 2, 2024 11:38
Copy link
Member

@psychology50 psychology50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하나 확인이 필요한 게 있어서 커멘트 남깁니다!
다른 하나는 의견이 궁금해서 남겨요

@asn6878 asn6878 requested a review from psychology50 July 3, 2024 13:58
@psychology50
Copy link
Member

merge하고 불러주시면 바로 승인하겠습니다~

@asn6878 asn6878 merged commit 74e0081 into dev Jul 4, 2024
1 check passed
@asn6878 asn6878 deleted the feat/PW-384-delete-spendings branch July 4, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants