-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to documentation for metacat #472
Conversation
Adding more description to the config for metacat and adjusting text to avoid rendering issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of little extras pls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple more things to clarify
This reverts commit 2737ced.
Fixed the formatting issue, all looks good now finally! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On top of my few comments:
- I think I left a separate comment on
disable_component_lock
that's not a part of the 'review' - There's currently linting issues that need to be addressed for the GHA workflow to be successful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@shubham-s-agarwal Just an FYI for the future, let's try to squash-and-merge when merging in PRs. That way we don't pollute the master branch with a bunch of commits with messages that are only relevant to the PR, not the whole project. By squashing, we only keep the relevant information from the P. When a PR is ready to merge, there's a drop down for merging. Once you've selected squash and merge once, it should remember it for the next time. |
That makes sense, I'll be sure to do that from next time. |
Adding more description to the config for metacat and adjusting text to avoid rendering issues