Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-86956du3q revisit regression #470

Merged
merged 137 commits into from
Aug 28, 2024
Merged

Commits on Jul 26, 2024

  1. Configuration menu
    Copy the full SHA
    8af5c72 View commit details
    Browse the repository at this point in the history
  2. CU-86956du3q: Update regression tests to a more reasonable state.

    Make sure to compare the correct annotation, not just hoping for any CUI annotated to match the one we are looking for.
    Output the specifics of the type of match that was found:
     - Identical
     - Bigger / smaller span
     - Random overlap
     - Parents / grandparetns, or children
    Add strictness options to summary (success / failure).
    mart-r committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    3437ed0 View commit details
    Browse the repository at this point in the history
  3. CU-86956du3q: Further fixes for regression checking:

    Remove 'Failure reason' and 'Failre descriptor' - now using Finding instead.
    Remove simplified success/failure metrics wherever relevant.
    Fix tests that relied on old logic and fix test-time replacement/cui location.
    mart-r committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    f455bb7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f71a206 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cc02104 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    52f6344 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a2837c8 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. CU-86956du3q: Update regression checking to generate multiple sub-cas…

    …es for multiple placeholders
    mart-r committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    343d0b1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fd6690b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    87183cd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f7f7ff3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    90e1227 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5910629 View commit details
    Browse the repository at this point in the history
  7. CU-86956du3q: Fix targeting

    mart-r committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f1b4799 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9c53cc6 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    beb0444 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    1d75257 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d3a565e View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    6e304aa View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    6b870e6 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    95d92a3 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    6504bac View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    a7bb30c View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    0eb8bdf View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    f661129 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    d7e59a3 View commit details
    Browse the repository at this point in the history
  20. CU-86956du3q: Allow multiple of the same placeholder in a phrase.

    And more specifically, treat each one as their own sub-case
    mart-r committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    b8ce24c View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    0d45b1f View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    667c009 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    98f7245 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Configuration menu
    Copy the full SHA
    c0a7747 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bcc49ba View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ba483ae View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3a776a2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2238e1d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b43de39 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    747f8e5 View commit details
    Browse the repository at this point in the history
  8. CU-86956du3q: Add storage of examples (of a certain strictness) as we…

    …ll as relevant output
    mart-r committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    a8e709b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    10f4f8a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    bb005fd View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    5970cd6 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    5b9a1f2 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    edf2e3d View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    251e720 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    e0a3c5c View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Configuration menu
    Copy the full SHA
    8528e74 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    81a5cb3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    66565a4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4d41ca5 View commit details
    Browse the repository at this point in the history
  5. CU-86956du3q: Update example checking with strictness requirement (in…

    …stead of simple boolean)
    mart-r committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    5eee717 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b79e5f0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    894fb0f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    cf9dd22 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c3be60f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    c0f99cf View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4d0bc6e View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    df12eba View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    2e7465d View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    e40ec4b View commit details
    Browse the repository at this point in the history
  15. CU-86956du3q: Remove option to set the total for progress bar (the au…

    …tomated one works fine now)
    mart-r committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    172f101 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    a7670e3 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    7f429d7 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    5bc1ee4 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    17fb479 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    7ea65a5 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    8860309 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    7629ac4 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    ca600b4 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    54ceca4 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    1dc8eaf View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Configuration menu
    Copy the full SHA
    c210ef2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e090704 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    05b490c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a086f37 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6606cd2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cd243aa View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    846a408 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4fd8088 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. CU-86956du3q: Add option to for failing with having found another con…

    …cept.
    
    Added other incorrect cui that was found (if applicable).
    Fixed issue with finding grandparents.
    mart-r committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    72ec064 View commit details
    Browse the repository at this point in the history
  2. CU-86956du3q: Add tests for parent and grandparent finding; fix tests…

    … for new changes (with optionally found alternative CUI)
    mart-r committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    e4f203e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5d9b08e View commit details
    Browse the repository at this point in the history
  4. CU-86956du3q: Fix tests for new form of determine cui description; ad…

    …d test for exact span grandchild
    mart-r committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    7683a88 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    741675e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d7bcd06 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Fixing bug for metacat

    Fix issues with compute_class_weights JSON serialization and enforce fc2 usage when fc3 is enabled
    
    * Resolved an issue where compute_class_weights returns a NumPy array, causing an error when saving the configuration as JSON (since JSON does not support NumPy arrays). The fix ensures compatibility by converting the NumPy array to a JSON-serializable format.
    
    * Added a safeguard in the model_architecture_config for meta_cat_config. The current architecture assumes fc3 is only used when fc2 is enabled. If fc2 is set to False and fc3 is True, the model would fail due to a mismatch in hidden layer sizes. The fix automatically enables fc2 if fc3 is set to True, preventing potential errors.
    shubham-s-agarwal authored and mart-r committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    94b16ab View commit details
    Browse the repository at this point in the history
  2. CU-86956duhb: Add method to backport a model pack from 1.12 to previo…

    …us version (#465)
    
    * CU-86956duhb: Add method to backport a model pack from 1.12 to previous version
    
    * CU-86956duhb: Fix some doc string issues
    
    * CU-86956duhb: Add deprecation decorator to old config-fix
    
    * CU-86956duhb: Mark backporting method as deprecated and to be removed in 1.14
    mart-r committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    7116ac7 View commit details
    Browse the repository at this point in the history
  3. CU-8694cd9t2: Allow merging config into model pack config before init (

    …#462)
    
    * CU-8694cd9t2: Allow merging config into model pack config before init
    mart-r committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    09ec3d4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6fb68c2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fc4ee7f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    680ad64 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cad3cb2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2aa6370 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b7e8c3c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    37ebb51 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c165bb5 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    a894ed1 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    eb0e26a View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    9187752 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    c29dc33 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    f416dd1 View commit details
    Browse the repository at this point in the history
  17. CU-86956du3q: Add comment for only using preferred names to the defau…

    …lt regression suite yaml
    mart-r committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    97326a2 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    e5da37b View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    4f30c68 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    6a88d97 View commit details
    Browse the repository at this point in the history
  21. CU-86956du3q: Add more tests for runtime doc string addition (to make…

    … sure it fails without the change)
    mart-r committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    2491bef View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    5d3fad9 View commit details
    Browse the repository at this point in the history
  23. CU-86956du3q: Add CLI option to show the various descriptions of the …

    …finding types (--only-describe)
    mart-r committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    7bf7f59 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Configuration menu
    Copy the full SHA
    a51f8b0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a7ebafd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4e7a106 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e5db542 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    46b66cf View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cfc0209 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    11211a5 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. CU-86956du3q: Make sure strictness propagates accross all parts of a …

    …multi-result descriptor
    mart-r committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    ea97a63 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b582366 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Configuration menu
    Copy the full SHA
    90be850 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2390a0f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4c3cc3e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4000280 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f70386a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    682950e View commit details
    Browse the repository at this point in the history
  7. CU-86956du3q: Add new part to main workflow to create and regression …

    …check a simple model pack
    mart-r committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    b71d1ef View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    eec8fec View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3f10fcd View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    9fe402f View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    0ddd4a7 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    1515548 View commit details
    Browse the repository at this point in the history
  13. CU-86956du3q: Use the python version of creat model pack during test …

    …time to avoid conflicts with other python versions running in parallel
    mart-r committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    ba35759 View commit details
    Browse the repository at this point in the history
  14. CU-86956du3q: [TEMP] Remove tests from main workflow (for faster iter…

    …ation) and add args to output upon regression checking
    mart-r committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    4bf3089 View commit details
    Browse the repository at this point in the history
  15. Revert "CU-86956du3q: [TEMP] Remove tests from main workflow (for fas…

    …ter iteration) and add args to output upon regression checking"
    
    This reverts commit 4bf3089.
    mart-r committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    750e9b8 View commit details
    Browse the repository at this point in the history
  16. CU-86956du3q: Make full model path the last line of the output upon c…

    …reation model for regression
    mart-r committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    b23aba0 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    32ebe7f View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    101f2e4 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    068c2bf View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Configuration menu
    Copy the full SHA
    b5a5b6a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6e23316 View commit details
    Browse the repository at this point in the history