Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-8694dpy1c: Restrict mypy to below 1.10.0 #422

Closed
wants to merge 1 commit into from

Conversation

mart-r
Copy link
Collaborator

@mart-r mart-r commented Apr 25, 2024

mypy 1.10.0 was released yesterday.
Turns out it has a new feature where it doesn't work well with a few of our methods (meta_cat.pipe and transformers_ner.pipe).
The underlying reason is that the methods are supposed to be generators, but they have fallback returns as well.
This was fine in mypy 1.9.0 but now fails in 1.10.0.

So the easiest thing to do is to limit the mypy version.

I don't fully know why these fallbacks of returning the empty stream exist, so I'm hesitent in removing it.

@tomolopolis
Copy link
Member

Copy link
Member

@baixiac baixiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mart-r
Copy link
Collaborator Author

mart-r commented Apr 29, 2024

In favour of #423

@mart-r mart-r closed this Apr 29, 2024
@mart-r mart-r deleted the CU-8694dpy1c-mypy-bump branch August 12, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants