CU-8694dpy1c: Restrict mypy to below 1.10.0 #422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypy1.10.0 was released yesterday.Turns out it has a new feature where it doesn't work well with a few of our methods (
meta_cat.pipeandtransformers_ner.pipe).The underlying reason is that the methods are supposed to be generators, but they have fallback returns as well.
This was fine in
mypy1.9.0 but now fails in 1.10.0.So the easiest thing to do is to limit the
mypyversion.I don't fully know why these fallbacks of returning the empty stream exist, so I'm hesitent in removing it.