Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cu 8693u6b4u tests continue on fail #400

Merged
merged 7 commits into from
Feb 13, 2024

Conversation

mart-r
Copy link
Collaborator

@mart-r mart-r commented Feb 13, 2024

I added continue-on-error: true to the main workflow tests step for testing purposes, but looks like I've not removed it before merging.
So now, tests will be marked "passed" regardless of whether or not they fail in GHA.

This PR removed that from the tests in the main workflow.

However, that still remains issues with the deid pipline which fails in multiprocessing.
So I've devised a way to (hopefully) force the installation of cpu-only torch for the deid tests.

Because this now means that without change the deid multiprocessing tests fail, I've also tackled that.
What this PR does is, for the deid multiprocessing test case, set the number of threads to 1 ontorch.
PS: The test runs fine without that locally. But stalls on Actions. So I don't really fully know what's the issue.

@tomolopolis
Copy link
Member

Task linked: CU-8693u6b4u GHA continues on test failure

Copy link
Member

@tomolopolis tomolopolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mart-r mart-r merged commit d01084c into master Feb 13, 2024
5 checks passed
mart-r added a commit that referenced this pull request Feb 13, 2024
* CU-8693u6b4u: Make sure failed/errored tests fail the main workflow

* CU-8693u6b4u: Attempt to fix deid multiprocessing, at least for GHA

* CU-8693u6b4u: Fix small docstring issue
mart-r added a commit that referenced this pull request Feb 28, 2024
* Cu 8693u6b4u tests continue on fail (#400)

* CU-8693u6b4u: Make sure failed/errored tests fail the main workflow

* CU-8693u6b4u: Attempt to fix deid multiprocessing, at least for GHA

* CU-8693u6b4u: Fix small docstring issue

* CU-8693v3tt6 SOMED opcs refset selection (#402)

* CU-8693v3tt6: Update refset ID for OPCS4 mappings in newer SNOMED releases

* CU-8693v3tt6: Add method to get direct refset mappings

* CU-8693v3tt6: Add tests to direct refset mappings method

* CU-8693v3tt6: Fix OPCS4 refset ID selection logic

* CU-8693v3tt6: Add test for OPCS4 refset ID selection

* CU-8693v6epd: Move typing imports away from pydantic (#403)

* CU-8693qx9yp Deid chunking - hugging face pipeline approach (#405)

* Pushing chunking update

* Update transformers_ner.py

* Pushing update to config

Added NER config in cat load function

* Update cat.py

* Updating chunking overlap

* CU-8693qx9yp: Add warning for deid multiprocessing with (potentially) non-functioning chunking window

* CU-8693qx9yp: Fix linting issue

---------

Co-authored-by: mart-r <[email protected]>

---------

Co-authored-by: Shubham Agarwal <[email protected]>
@mart-r mart-r deleted the CU-8693u6b4u-tests-continue-on-fail branch March 1, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants