Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-8692kn0yv Fix issue with fake dict in identifier based config #341

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

mart-r
Copy link
Collaborator

@mart-r mart-r commented Aug 23, 2023

More specifically the get method which was not able to return default values for non-existant keys.

This PR will make sure the __getitem__ method of FakeDict will raise a KeyError as would be expected for a dict instead of an AttributionError (which was the case up until now).
This will ensure that the FakeDict.get method will catch the correct exception in the except clause.

Issue raised here:
https://discourse.cogstack.org/t/attribute-error-for-medcat-trainer/234

…e specifically the get method which was not able to return default values for non-existant keys
S2P2 added a commit to S2P2/MedCAT that referenced this pull request Aug 29, 2023
Copy link
Member

@tomolopolis tomolopolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mart-r mart-r merged commit 3aaef44 into CogStack:master Sep 4, 2023
5 checks passed
@mart-r mart-r deleted the idConfigHotfix23Aug branch September 8, 2023 08:38
mart-r added a commit that referenced this pull request Sep 21, 2023
* remove bad merge <p> element

* CU-8692kpchc Fix for Rosalind link not working (#342)

* CU-8692kpchc Add the 403 exception to vocab downloader

* CU-8692kpchc Add the new vocab download link

* Add missing self argument (#343)

To `_refset_df2dict ` method in Snomed preprocessing

* CU-8692kn0yv Fix issue with fake dict in identifier based config

More specifically the get method which was not able to return default values for non-existant keys (#341)

* CU-8692mevx8 Fix issue with filters not taking effect in train_supervised method (#345)

* CU-8692mevx8 Fix issue with filters not taking effect in train_supervised method

* CU-8692mevx8 Fix filter retention in train_supervised method

---------

Co-authored-by: tomolopolis <[email protected]>
mart-r added a commit to mart-r/MedCAT that referenced this pull request Sep 21, 2023
More specifically the get method which was not able to return default values for non-existant keys (CogStack#341)
mart-r added a commit that referenced this pull request Sep 21, 2023
More specifically the get method which was not able to return default values for non-existant keys (#341)
mart-r added a commit that referenced this pull request Sep 21, 2023
* CU-8692kn0yv Fix issue with fake dict in identifier based config

More specifically the get method which was not able to return default values for non-existant keys (#341)

* Bump run target to Ubuntu 20.04 since 18.04 targets do not exist anymore

* Bump main worfklow target to 20.04 as well
mart-r added a commit to mart-r/MedCAT that referenced this pull request Sep 21, 2023
More specifically the get method which was not able to return default values for non-existant keys (CogStack#341)
mart-r added a commit that referenced this pull request Sep 22, 2023
More specifically the get method which was not able to return default values for non-existant keys (#341)
mart-r added a commit that referenced this pull request Sep 22, 2023
More specifically the get method which was not able to return default values for non-existant keys (#341)
mart-r added a commit that referenced this pull request Oct 12, 2023
More specifically the get method which was not able to return default values for non-existant keys (#341)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants