Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/auth #15

Merged
merged 2 commits into from
Nov 18, 2019
Merged

Feature/auth #15

merged 2 commits into from
Nov 18, 2019

Conversation

Fraasi
Copy link
Contributor

@Fraasi Fraasi commented Nov 17, 2019

I read thru the keystone examples and refractored my first attempt. I think this is a much more solid foundation to build more precise access levels and API's as this thing grows.

@vimkat
Copy link
Member

vimkat commented Nov 18, 2019

Looks good, @Fraasi! 🎉
I'm not super-happy about the current data model but that's another discussion anyway.
Thanks for this! Good to merge in my opinion! 👍

@gruselhaus Any other thoughts?

Copy link
Member

@gruselhaus gruselhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go for it :)

@gruselhaus gruselhaus merged commit 85c359e into CodingTrain:develop Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants