Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give frame work to add additional activation functions #45

Merged
merged 4 commits into from
Feb 10, 2018

Conversation

schrummy14
Copy link
Contributor

This, should, allow the use of additional activation functions

@shiffman
Copy link
Member

shiffman commented Feb 9, 2018

This is great! Do you think it makes sense to refactor sigmoid() and any future functions to be static() methods of NeuralNetwork or namespaced in some way?

@schrummy14
Copy link
Contributor Author

For a "toy" I don't see the harm in people being able to call the function from outside the nn but that is something that definitely could be done to make sure the functions work the way their suppose to.

@shiffman shiffman merged commit b147cba into CodingTrain:master Feb 10, 2018
@shiffman
Copy link
Member

Great, merging in for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants