Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amended Pipe Design #46

Merged
merged 3 commits into from
Apr 9, 2018
Merged

Amended Pipe Design #46

merged 3 commits into from
Apr 9, 2018

Conversation

A-Edusei
Copy link
Contributor

@A-Edusei A-Edusei commented Apr 6, 2018

Hi I have addressed the issue #44 regarding the collision problem, by uploading a slightly altered version of the previous pipe design. I believe the issue was to do with the transparent sections which could not be seen by the player however it was still registering as a "HIT". This has been addressed by filling these transparent sections with a graphic (that still compliments the previous design) that the player can see and avoid.

A-Edusei added 3 commits April 6, 2018 14:08
This is an edited pipe design for issue CodingTrain#44 addressing the collision problem
I have replaced the current pipe design with a slightly altered version which addresses the collision issue pointed out in issue CodingTrain#44. The issue was to do with the transparent section in which the bird/unicorn sprite kept hitting.
Fixed Collision Issue With Pipes
@shiffman
Copy link
Member

shiffman commented Apr 9, 2018

Hello! I'm interested in this! But I don't see the new png files as part of this pull request. Am I missing something? Also, it's helpful if you can run github pages via your repo and then link to it from here so that I can review without having to download.

Thank you!

@shiffman
Copy link
Member

shiffman commented Apr 9, 2018

Apologies I see the files are there now, merging!

@shiffman shiffman merged commit c2a74bd into CodingTrain:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants