Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

game 'restarts' if you hit pipe #34

Closed
wants to merge 4 commits into from
Closed

Conversation

DaGuT
Copy link
Contributor

@DaGuT DaGuT commented Mar 10, 2018

No description provided.

@DaGuT
Copy link
Contributor Author

DaGuT commented Mar 10, 2018

#29 (comment)
done

@matcool
Copy link
Contributor

matcool commented Mar 10, 2018

You forgot to add a pipe to the pipes array and setting frameCount = 1 doesnt work properly.

@matcool
Copy link
Contributor

matcool commented Mar 10, 2018

From what i can see and from testing you only cleared the pipes array but did not add a new one.
When testing i got the error TypeError: pipes[i] is undefined due to the pipes array being empty

@DaGuT
Copy link
Contributor Author

DaGuT commented Mar 10, 2018

I could not delete my comment, sry.

Gonna figure out what to do with frameCount and reopen pull

@DaGuT DaGuT closed this Mar 10, 2018
@DaGuT DaGuT reopened this Mar 10, 2018
@DaGuT
Copy link
Contributor Author

DaGuT commented Mar 10, 2018

fixed :D

@matcool
Copy link
Contributor

matcool commented Mar 10, 2018

Tried it and it works!
I also tried to make the game restart by creating a pipetimer variable
8c8066c

@shiffman
Copy link
Member

I'd like to let @simon-tiger have a chance to add this in #29 since it was first submitted during the live stream.

@shiffman
Copy link
Member

Handled in #29, thank you for the contribution!

@shiffman shiffman closed this Mar 13, 2018
@DaGuT
Copy link
Contributor Author

DaGuT commented Mar 13, 2018

yeah, gonna fix it now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants