Merge pull request #47 from cashlionjp/patch-1

Update pipe.js
CodingTrain · Apr 28, 2018 · 420c09c · 420c09c
2 parents bc3f2d7 + a6720d1
commit 420c09c
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/pipe.js b/pipe.js
@@ -21,9 +21,11 @@ class Pipe {
   }
 
   hits(bird) {
-    if (bird.y - bird.height / 2 < this.top || bird.y + bird.height / 2 > this.bottom) {
+    let halfBirdHeight = bird.height / 2;
+    let halfBirdwidth = bird.width / 2;
+    if (bird.y - halfBirdHeight < this.top || bird.y + halfBirdHeight > this.bottom) {
       //if this.w is huge, then we need different collision model
-      if (bird.x + bird.width / 2 > this.x && bird.x - bird.width / 2 < this.x + this.w) {
+      if (bird.x + halfBirdwidth > this.x && bird.x - halfBirdwidth < this.x + this.w) {
         this.highlight = true;
         this.passed = true;
         return true;