This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Create Contributors page #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiray
suggested changes
Oct 7, 2019
| <p> | ||
| <a v-bind:href="`https://github.com/${data.attributes.username}`"> | ||
| <i class="fa fa-github-square"></i> | ||
| <span>{{ data.attributes.username }}</span> |
There was a problem hiding this comment.
There should be left padding on this.
| @@ -0,0 +1,33 @@ | |||
| <template> | |||
| <div class="contributors"> | |||
| <div class="contributor" v-for="contributor in contributors" :key="contributor.id"> | |||
There was a problem hiding this comment.
This is giving a linting error.
| return ( | ||
| fetch('https://api-dev.codinggarden.community/contributors') | ||
| .then(res => res.json()) | ||
| // eslint-disable-next-line |
There was a problem hiding this comment.
Let's fix the issues and follow the linter.
|
I don't know why there are those linting errors @spiray , my linter isn't complaining and the code auto-prettifies when I push. I'll look at it, though. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created contributors page, and updated the leaves component.
Styles may need to be refactored.