Skip to content

Added missing artifact - single file CLI demo for windows #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stesee merged 1 commit into from
Jan 22, 2023
Merged

Added missing artifact - single file CLI demo for windows #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ jobs:
./Codeuctivity.HtmlRenderer/bin/Release/*.nupkg
./Codeuctivity.HtmlRenderer/bin/Release/*.snupkg
./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfilePortable/Codeuctivity.HtmlRendererCli.Portable.zip
./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfileWindows/Codeuctivity.HtmlRendererCli.exe

deployTest:
if: github.ref == 'refs/heads/main'
Expand Down Expand Up @@ -125,3 +126,4 @@ jobs:
./Codeuctivity.HtmlRenderer/bin/Release/*.nupkg
./Codeuctivity.HtmlRenderer/bin/Release/*.snupkg
./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfilePortable/Codeuctivity.HtmlRendererCli.Portable.zip
./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfileWindows/Codeuctivity.HtmlRendererCli.exe
2 changes: 1 addition & 1 deletion Codeuctivity.HtmlRenderer/Renderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public Renderer(LaunchOptions? launchOptions = null)
/// <summary>
/// Browser fetcher - used to get chromium bins
/// </summary>
public BrowserFetcher BrowserFetcher { get; private set; }
public BrowserFetcher? BrowserFetcher { get; private set; }

private LaunchOptions LaunchOptions { get; }

Expand Down
2 changes: 1 addition & 1 deletion Codeuctivity.HtmlRendererTests/RendererTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public async Task ShouldConvertHtmlToPdfWithOptions(string testFileName, bool pr
}
catch (InvocationException ex)
{
// Working around issue in Jering.Javascript.NodeJS, silencing false positiv failing
// Working around issue in Jering.Javascript.NodeJS, silencing false positive failing
Assert.True(RuntimeInformation.IsOSPlatform(OSPlatform.Windows), ex.Message);
}
}
Expand Down