Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CustomEvent not properly triggering jQuery event for hidden fields workflow #408

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

Summary

I found out that native CustomEvent and jQuery.trigger are not the same. I added back the event trigger via jQuery for conditions workflow.

Will affect visual aspect of the product

NO

Test instructions

  • Import those fields
    ppom-meta-1728379034.csv
  • The hidden field should not be added to the price when adding the item to cart.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/ppom-pro

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Oct 8, 2024
@pirate-bot pirate-bot added the pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) label Oct 8, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel added pr-checklist-skip Allow this Pull Request to skip checklist. and removed pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Oct 8, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Oct 8, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Oct 8, 2024

Plugin build for 7531c36 is ready 🛎️!

@selul selul merged commit 2b24b23 into development Oct 8, 2024
4 checks passed
@selul selul deleted the fix/hidden-fields-on-price branch October 8, 2024 14:43
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 33.0.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants