Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add fields re-ordering for JSON payload #405

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Oct 8, 2024

Summary

Because the group field saving payload was switched to JSON in e30abe0, the JSON object does not keep the initial order of its key. Thus, we need to reorder the fields before processing them.

Will affect visual aspect of the product

NO

Test instructions

  • Create a new group field with 2 or more input fields
  • Check if you can re-order them.

Check before Pull Request is ready:

Closes #404

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Oct 8, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Oct 8, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Oct 8, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Oct 8, 2024

Plugin build for 243d4b8 is ready 🛎️!

@selul selul merged commit 1bf370a into development Oct 8, 2024
4 checks passed
@selul selul deleted the fix/meta-reorder branch October 8, 2024 13:52
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 33.0.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to reorder the fields in a meta group
3 participants