fix: improper usage of the_content filter #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preda-bogdan
approved these changes
Mar 12, 2024
|
🎉 This PR is included in version 32.0.14 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This issue was introduced with the fixes for this #159 .
The problem was the usage of
the_contentfilter to render the shortcodes, although it had fixed the shortcode rendering it was not the proper place to usethe_contentfilter as only a small part of the page was rendered there i.e. the field description.The proposed fix uses the
do_shortcodefunction before outputting the field description.I tested with the solution and the reviews are working as expected and also the shortcodes are still replaced.
Will affect visual aspect of the product
NO
Test instructions
Follow the linked issue details.
It is also good to test that #159 is not reintroduced.
Closes #261.