Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPOM Texter Popup is too big #183

Closed
AndreeaCristinaRadacina opened this issue Nov 14, 2023 · 4 comments · Fixed by #185
Closed

PPOM Texter Popup is too big #183

AndreeaCristinaRadacina opened this issue Nov 14, 2023 · 4 comments · Fixed by #185
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@AndreeaCristinaRadacina

Description

Depending on the image size used when configuring the PPOM Texter, its dimension is different, so the user might need to scroll to see the whole content, which is not very user-friendly.

Also, in my case, I was using Neve and a header on 3 rows, so I could not even see the text area inside the texter.

Identified while working on this - https://secure.helpscout.net/conversation/2420296070/392746?folderId=212385

Step-by-step reproduction instructions

  1. Go to PPOM Texter
  2. Configure a new texter and use a large image
  3. Go to WooCommerce > PPOM Fields
  4. Create a new group using the PPOM Texter field
  5. Go to the front page and check the results

Screenshots, screen recording, code snippet or Help Scout ticket

image

See live behavior here - https://root.stefancoti.com/product/chicken-sticks/

Environment info

No response

Is the issue you are reporting a regression

No

@AndreeaCristinaRadacina AndreeaCristinaRadacina added the bug This label could be used to identify issues that are caused by a defect in the product. label Nov 14, 2023
@pirate-bot pirate-bot added the customer report Indicates the request came from a customer. label Nov 14, 2023
@girishpanchal30 girishpanchal30 linked a pull request Nov 16, 2023 that will close this issue
@irinelenache
Copy link

@AndreeaCristinaRadacina @girishpanchal30 This is how it works for me with some larger images https://vertis.d.pr/v/xRpXwl Is this expected? I didn't exactly understand the issue

@girishpanchal30
Copy link
Contributor

@irinelenache It might be a cache issue, can you please verify whether my changes are there or not in your test environment?
Ref: 2fc6bf1

@irinelenache
Copy link

@girishpanchal30 I checked again on a fresh instance and it works fine now, sorry about the caching issue 🙏

@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 32.0.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants