Promos Adjustments

[abaicus]

Changes summary:

• Simplifies the CF7 Redirection plugin notice;
• Decouples promotion delay so we can enable it individually per promo;
• Removes the Neve FSE promo and replaces it with a Neve promo;
• Removes the delay for Sparks & PPOM notices;
• Reworks the Optimole promos stacked layout;
• Removes the email registration flow from the Optimole promos;
• Changes how the Optimole promos are displayed according to what was stated here: https://github.com/Codeinwp/themeisle/issues/1656#issuecomment-2264977637;

---

Testing instructions:

Tip

You can use the debug filter to show all the notices available in the SDK. Just add the filter below to a mu-plugin, or use the QA plugin built in the comment to this PR.
add_filter( 'themeisle_sdk_promo_debug', '__return_true' );

CF7 Redirection notice:

• Be sure that you're enabling debug using the filter so the promo shows up;
• Install Contact Form 7;
• Go to its' main admin page;
• The notice should be visible & work just like before;

Neve Notice:

• Go to the themes.php admin page;
• The new Neve notice should have replaced the Neve FSE notice;
• The notice should work as expected and show up without any delay;
• If the theme is active, it should not show up;
• If the theme is installed but not active, it should prompt for activation;
• If the theme is not installed, it should prompt for installation and activation;
• If the theme has been installed and activated via the promo, it should not show up;

PPOM & Sparks notices:

• Install WooCommerce and create a product;
• In the product edit admin page, the Sparks & PPOM promos should show up without needing any additional steps taken;

Optimole notices:

• Enable the debug filter mentioned in the steps above;
• Check the promos described in this comment: https://github.com/Codeinwp/themeisle/issues/1656#issuecomment-2264977637
• They should all work as expected;
• The email step has been removed from the flow of the Optimole notices;

---

Closes Codeinwp/themeisle#1654
Closes Codeinwp/themeisle#1655
Closes Codeinwp/themeisle#1656

[github-actions]

Plugin build for c13ebf0 is ready 🛎️!

• Download Themeisle SDK QA Plugin - build 🔗

[carlalexander]

Ok, I've done a first pass just looking at the code. There are a few logic things, but mainly I want to promote the use of the ternary operator as much as possible. We can discuss how that might look like with large HTML blocks to make it readable.

There are a lot of commits in this PR. If you want to start looking at merging the chore commits to their respective commits. That would be good. Otherwise, we can leave that for the end.

[abaicus]

@carlalexander I've addressed the issues you pointed out. Let me know if you think there are more things that could be improved. Thank you!

[carlalexander]

@abaicus This all looks great. Thank you!

Next, we should try to merge some of the commits together and clean up the commit history as I mentioned:

There are a lot of commits in this PR. If you want to start looking at merging the chore commits to their respective commits. That would be good. Otherwise, we can leave that for the end.

[abaicus]

@carlalexander It should be fine now. Some commits were mislabeled as chore instead of fix. Let me know if there's anything else left here! Thank you!

[carlalexander]

This looks a lot better! I'd rather we didn't have a commit for the code review changes, but this PR is too big.

Another thing I noticed is that all the fix commits didn't have any tests. Not sure if there's a large test suite in the SDK. But something I'll look at more next time.

Great work!! 🙌

[pirate-bot]

🎉 This PR is included in version 3.3.28 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀