Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: string translation for PHP and JS #392

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Oct 9, 2024

Summary

  • Fix the string translation issues for both Js and PHP
  • Fix JS lint and include the i18n check for PHPCS
  • Update GA

Generated .pot file: templates-patterns-collection.pot.zip

Will affect visual aspect of the product

NO

Screenshots

Test instructions

Check the strings in the .pot file compared to the plugin.

Check before Pull Request is ready:

Closes #384

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Oct 9, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Oct 9, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Oct 9, 2024
@pirate-bot
Copy link
Collaborator

pirate-bot commented Oct 9, 2024

Plugin build for 7d84a72 is ready 🛎️!

@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Oct 9, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare the plugin for localization
2 participants