Documentation notice after import #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HardeepAsrani
requested changes
Aug 1, 2023
| return ( | ||
| <div className="doc-notice"> | ||
| { url ? ( | ||
| <a |
There was a problem hiding this comment.
We can use the <ExternalLink component from Gutenberg instead of <a as it adds the icon before the link as Design team has asked: 
https://developer.wordpress.org/block-editor/reference-guides/components/external-link/
There was a problem hiding this comment.
Hey @HardeepAsrani, I thought about that but the Icon is after https://wordpress.github.io/gutenberg/?path=/story/components-externallink--default.
HardeepAsrani
approved these changes
Aug 1, 2023
|
@cristian-ungureanu Tested and everything's fine here 👍 |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added the documentation notice after the import. The documentation notice is only visible if the import process is successful and if the starter site has the doc_url property defined in this file: https://github.com/Codeinwp/demo-data-exporter/blob/master/front-end/class-dde-frontend.php
Test instructions
functions.phpfileNote: I still have to add the doc_url parameter inside the exporter, I'm waiting for an answer regarding the links.
Closes Codeinwp/neve#3956, #247.