Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Deprecated warning on Import for php 8.1 #265

Closed
preda-bogdan opened this issue Jul 20, 2023 · 1 comment
Closed

Bug: Deprecated warning on Import for php 8.1 #265

preda-bogdan opened this issue Jul 20, 2023 · 1 comment
Assignees
@preda-bogdan
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product. tiny (1h) - This label is used for issues that can be completed in under an hour.

Comments

@preda-bogdan
Copy link
Contributor

Description

When importing a Starter Site on php8.1 a deprecation warning is logged.

PHP Deprecated:  Automatic conversion of false to array is deprecated in /Users/bogdan/www/html/plugins/templates-patterns-collection/includes/Importers/Cleanup/Active_State.php on line 123

The import completes ok for now, it might cause issues on future PHP versions.

Step-by-step reproduction instructions

  1. Use php8.1
  2. Import a Starter Site
  3. Check the PHP logs.

Screenshots, screen recording, code snippet or Help Scout ticket

No response

Environment info

No response

Is the issue you are reporting a regression

No
@preda-bogdan preda-bogdan added the bug This label could be used to identify issues that are caused by a defect in the product. label Jul 20, 2023
@preda-bogdan preda-bogdan self-assigned this Jul 20, 2023
@preda-bogdan preda-bogdan added the tiny (1h) - This label is used for issues that can be completed in under an hour. label Jul 20, 2023
preda-bogdan added a commit that referenced this issue Jul 20, 2023
@preda-bogdan
fix: php8.1 warning on import #265
40086a0
@preda-bogdan preda-bogdan mentioned this issue Jul 20, 2023
Merged
@preda-bogdan preda-bogdan changed the title Bug: Depregated warning on Import for php 8.1 Bug: Deprecated warning on Import for php 8.1 Jul 20, 2023
cristian-ungureanu pushed a commit that referenced this issue Sep 15, 2023
Merge pull request #266 from Codeinwp/fix/php81_compatibility
8f297c7 
fix: php8.1 warning on import #265
@pirate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@preda-bogdan preda-bogdan

Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product. tiny (1h) - This label is used for issues that can be completed in under an hour.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cristian-ungureanu @preda-bogdan @pirate-bot