Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compatibility for Spectra #580

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Add compatibility for Spectra #580

merged 2 commits into from
Jun 30, 2023

Conversation

HardeepAsrani
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Add compatibility with Spectra blocks.

Closes #571.

How to test the changes in this Pull Request:

  1. Make sure Optimole's serve CSS/JS option is disabled.
  2. Make sure File Generation is enabled in Spectra.
  3. All the images used in Blocks should be served through Optimole.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@HardeepAsrani HardeepAsrani changed the base branch from master to development June 29, 2023 10:25
@pirate-bot
Copy link
Collaborator

Plugin build for e7765db is ready 🛎️!

abaicus
abaicus approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@abaicus abaicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻 Thank you, @HardeepAsrani! 🚀

@irinelenache
Copy link

@HardeepAsrani Tested and the issue is fixed now, thank you 🚀

@abaicus abaicus merged commit 3bc6327 into development Jun 30, 2023
@abaicus abaicus deleted the issue/fix-571 branch June 30, 2023 14:35
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 3.8.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abaicus abaicus abaicus approved these changes

Assignees
No one assigned
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image backgrounds from Spectra blocks are not optimized
4 participants
@HardeepAsrani @pirate-bot @irinelenache @abaicus