-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHPStan #568
Add PHPStan #568
Conversation
@HardeepAsrani Regarding the error you mentioned I did some tests and the type of It's safe to change the type on the function param declaration to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HardeepAsrani I think other than what @GrigoreMihai mentioned, this should be ok to go 👍🏻 Thanks for addressing all the other issues! 🚀
@HardeepAsrani Tested the PR and didn't find any problem 🚀 |
🎉 This PR is included in version 3.8.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
This adds PHPStan to level 5 and changes have been made to best of my knowledge, so it will be good to have a review to make sure no changes are reverting intended code.
Also, there is one error left in PHPStan which I'm not able to realize why that particular line of code was written the way it is written so feedback there is appreciated.
Closes #566.
How to test the changes in this Pull Request:
Other information: