Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default lazy images are still loaded from client server #81

Closed
ineagu opened this issue Mar 12, 2019 · 2 comments
Closed

default lazy images are still loaded from client server #81

ineagu opened this issue Mar 12, 2019 · 2 comments
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@ineagu
Copy link
Contributor

ineagu commented Mar 12, 2019

Describe the bug

When you visit this page :https://inkmeetspaper.com/product/here-for-you/?attribute_pa_count=single-card as you can see below https://www.dropbox.com/s/ku6p66z84cxopre/Screenshot%202019-03-12%2011.08.21.png?dl=0 there are still images coming from client-server, it seems to be a problem on this part of the code : https://www.dropbox.com/s/8cos4hho4fegdc3/Screenshot%202019-03-12%2011.11.10.png?dl=0
@selul
Copy link
Contributor

selul commented Mar 12, 2019

just a note here, it's related to the json attribute generated by the variation form, which replacer somehow misses. might be due to the htmlentities.

@selul selul closed this as completed in 2bae741 Mar 25, 2019
selul pushed a commit that referenced this issue Mar 25, 2019
@semantic-release-bot
chore(release): 2.0.5 [skip ci]
17879b4 
#### [Version 2.0.5](v2.0.4...v2.0.5) (2019-03-25)

* **Bug Fixes**
   * adds compatibility with Jetelements Slider ([c9e518e](c9e518e))
   * compatibility with Metaslider, adds full support for all slider types available ([a09d1fd](a09d1fd))
   * compatibility with various themes logo markup based on the image url, removes the hook to theme_mods image replace ([34e0d85](34e0d85))
   * disable image replacement when we are in the Beaver Builder editing mode ([239442f](239442f))
   * image replacement on header tags which uses relative urls ([2caae7f](2caae7f))
   * image replacement on json strings with html entities encoded, conflicting with  variation form Woocommerce fixes [#81](#81) ([2bae741](2bae741))
   * lazyload animation conflict with initial image animation ([3a84250](3a84250))
   * lazyload on image which uses relative urls ([4655994](4655994))
   * lazyload placeholder replacement affecting non-src urls, improving compatibility with Woocommerce ([7e13a32](7e13a32))
   * noscript image tag issue causing problems with too specific CSS selectors ([324effd](324effd))
   * relative url image replacement conflicting with plugins like WPML ([7a47827](7a47827))
   * thumbnails cropping mode not affecting the resulting optimole images ([0f6dacb](0f6dacb))

* **Features**
   * adds constant to disable latest images area ([a5891b6](a5891b6))
   * adds constant to switch on/off network based optimization ([1accde5](1accde5))
   * adds full compatibility with Beaver Builder, processing images from the generated css ([2a17f30](2a17f30))
@selul
Copy link
Contributor

selul commented Mar 25, 2019

🎉 This issue has been resolved in version 2.0.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@selul selul added the released Indicate that an issue has been resolved and released in a particular version of the product. label Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ineagu @selul