Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove script tag on AMP, not only replacement #203

Closed
ineagu opened this issue Dec 31, 2019 · 1 comment
Closed

remove script tag on AMP, not only replacement #203

ineagu opened this issue Dec 31, 2019 · 1 comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@ineagu
Copy link
Contributor

ineagu commented Dec 31, 2019

@selul I see this warning in the AMP plugin on the latest version, I think it should not be there: https://www.dropbox.com/s/ykshyp881bgsp0v/Screenshot%202019-12-31%2010.48.09.png?dl=0
selul added a commit that referenced this issue Dec 31, 2019
@selul
fix: strip script tag on amp modes fix #203
567344e
@selul selul closed this as completed in 35f59f3 Jan 14, 2020
selul pushed a commit that referenced this issue Jan 14, 2020
@semantic-release-bot
chore(release): 2.2.8 [skip ci]
98a209f 
#### [Version 2.2.8](v2.2.7...v2.2.8) (2020-01-14)

* **Bug Fixes**
   * catch image URLs that contains some symbols ([ce1c162](ce1c162))
   * compatibility with Sassy Social share plugin ([d4224cb](d4224cb))
   * consider image URLs that contains chars like ~ ([670597e](670597e))
   * improve LQIP transition effect, fix [#212](#212) ([946e16c](946e16c))
   * prevent losing filters settings after disconnecting the api key, fix [#210](#210) ([db431b9](db431b9))
   * removes custom logo preload causing duplicate content issues ([04cad07](04cad07))
   * strip script tag on amp modes fix [#203](#203) ([35f59f3](35f59f3))

* **Features**
   * adds data-skip-lazy attr for skipping lazyload ([8726127](8726127))
   * adds wp-cli commands for most common operations ([577406b](577406b))
@selul
Copy link
Contributor

selul commented Jan 14, 2020

🎉 This issue has been resolved in version 2.2.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@selul selul added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ineagu @selul