Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compression level misunderstanding #162

Closed
ineagu opened this issue Oct 22, 2019 · 1 comment
Closed

compression level misunderstanding #162

ineagu opened this issue Oct 22, 2019 · 1 comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@ineagu
Copy link
Contributor

ineagu commented Oct 22, 2019

Describe the bug
After ignoring it for a while, when I gave it a fresh read I was confused by the setting name + description : https://www.dropbox.com/s/qn2otqtsn1woyko/Screenshot%202019-10-22%2010.21.07.png?dl=0

If I look at the name: "Compression Level", I assume the higher is the compression, the smaller is the image ( not sure if this is the case)

This is also confirmed by the description: "A higher compression means a loss in quality, so basically you are saying if I select high, I might lose quality.

Then when I check with the sample image thing, lower compression, results in smaller images ( lower quality).

Expected behavior
I would expect that images with higher compression results in the smallest ones.

Possible solutions:

  1. Keep the same slider and change the title/description :

a) Image quality

Lower image quality might not always be perceived by users and would result in a boost of your loading speed by lowering the page size. Try experimenting with the setting, then click the view sample image link to see what option works best for you.

cc @selul

@selul selul closed this as completed in 60cbe5e Nov 5, 2019
selul pushed a commit that referenced this issue Nov 5, 2019
#### [Version 2.2.3](v2.2.2...v2.2.3) (2019-11-05)

* **Bug Fixes**
   * change minimum slider range for compression to 50 instead of 0 ([592c3e2](592c3e2))
   * image quality setting description, fix [#162](#162) ([60cbe5e](60cbe5e))
   * improve description for background image lazyload fix [#163](#163) ([f0f190b](f0f190b))
   * upgrade notice when user is close to visits limit ([ff716f7](ff716f7))
@selul
Copy link
Contributor

selul commented Nov 5, 2019

🎉 This issue has been resolved in version 2.2.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@selul selul added the released Indicate that an issue has been resolved and released in a particular version of the product. label Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

No branches or pull requests

2 participants