Add support for external images replacement in editor if the domain i…

…s allowed.
Codeinwp · Aug 8, 2024 · b09a584 · b09a584
1 parent 1a3d048
commit b09a584
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/inc/media_offload.php b/inc/media_offload.php
@@ -2455,6 +2455,9 @@ public function replace_urls_in_editor_content( $content ) {
 
 			// No local attachment.
 			if ( $attachment['attachment_id'] === 0 ) {
+				if ( $this->can_replace_url( $url ) ) {
+					$to_replace[ $url ] = $this->get_optimized_image_url( $url, 'auto', 'auto' );
+				}
 				continue;
 			}
 

diff --git a/inc/traits/dam_offload_utils.php b/inc/traits/dam_offload_utils.php
@@ -259,7 +259,7 @@ private function attachment_url_to_post_id( $input_url ) {
 		$cached = Optml_Attachment_Cache::get_cached_attachment_id( $input_url );
 
 		if ( $cached !== false ) {
-			return $cached;
+			return (int) $cached;
 		}
 
 		$url = $this->strip_image_size( $input_url );

diff --git a/tests/test-media.php b/tests/test-media.php
@@ -174,7 +174,7 @@ public function setUp() : void {
 		$settings->update( 'service_data', [
 			'cdn_key'    => 'example',
 			'cdn_secret' => 'test',
-			'whitelist'  => [ 'example.com', 'example.org' ],
+			'whitelist'  => [ 'example.com', 'example.org','external.com' ],
 
 		] );
 		$settings->update( 'no_script', 'enabled' );
@@ -506,7 +506,15 @@ public function test_replace_urls_in_editor_content() {
 		$this->assertStringNotContainsString( '-scaled.'.$extension, $replaced_content );
 
 	}
+	public function test_replacement_editor_with_external_images(){
+		Optml_Attachment_Cache::reset();
+		$original_url = "https://external.com/image.png" ;
+		$content_before_replace = sprintf( '<img src="%s" />', $original_url);
+		$replaced_content = Optml_Media_Offload::instance()->replace_urls_in_editor_content( $content_before_replace );
 
+		$this->assertStringContainsString( $original_url, $replaced_content );
+		$this->assertStringContainsString( 'i.optimole.com', $replaced_content );
+	}
 	public function test_alter_attachment_image_src() {
 		$test_data = [
 			'full' => [