chore: fix PHPUnit tests

Codeinwp · Jul 28, 2023 · 39505cf · 39505cf
1 parent f204df0
commit 39505cf
Showing 1 changed file with 10 additions and 37 deletions.
diff --git a/tests/test-dam.php b/tests/test-dam.php
@@ -7,11 +7,6 @@ class Test_Dam extends WP_UnitTestCase {
 
 	const TEST_API_KEY = 'testkey';
 
-	/**
-	 * @var \WP_Post[] List of attachments inserted during the test.
-	 */
-	private $inserted_dam_attachments = array();
-
 	/**
 	 * @var int[] List of attachment IDs inserted during the test.
 	 */
@@ -77,15 +72,9 @@ class Test_Dam extends WP_UnitTestCase {
 
 	public function setUp(): void {
 		parent::setUp();
-
-		$settings = new Optml_Settings();
-		$settings->update('service_data', [
-			'cdn_key' => 'test123',
-			'cdn_secret' => '12345',
-			'whitelist' => ['example.com'],
-		]);
-
-		$this->add_image_sizes();
+		foreach ( self::IMAGE_SIZES as $slug => $args ) {
+			add_image_size( $slug, $args['width'], $args['height'], $args['crop'] );
+		}
 
 		$plugin         = Optml_Main::instance();
 		$this->dam      = $plugin->dam;
@@ -220,26 +209,26 @@ public function test_dam_size_gravity_replacer() {
 	public function test_alter_attachment_image_src() {
 		foreach ( $this->inserted_ids as $id ) {
 			$result = $this->dam->alter_attachment_image_src( false, $id, 'test_landscape', false );
-			$this->assertContains( 'w:200/h:100/g:ce/rt:fill', $result[0] );
+			$this->assertStringContainsString( 'w:200/h:100/g:ce/rt:fill', $result[0] );
 			$this->assertEquals( 200, $result[1] );
 			$this->assertEquals( 100, $result[2] );
 			$this->assertTrue( $result[3] );
 
 			$result = $this->dam->alter_attachment_image_src( false, $id, 'test_portrait', false );
-			$this->assertContains( 'w:100/h:200/g:ce/rt:fill', $result[0] );
+			$this->assertStringContainsString( 'w:100/h:200/g:ce/rt:fill', $result[0] );
 			$this->assertEquals( 100, $result[1] );
 			$this->assertEquals( 200, $result[2] );
 			$this->assertTrue( $result[3] );
 
 			$result = $this->dam->alter_attachment_image_src( false, $id, 'medium', false );
-			$this->assertContains( 'w:300/h:300/', $result[0] );
-			$this->assertNotContains( 'g:ce/rt:fill', $result[0] );
+			$this->assertStringContainsString( 'w:300/h:300/', $result[0] );
+			$this->assertStringNotContainsString( 'g:ce/rt:fill', $result[0] );
 			$this->assertEquals( 300, $result[1] );
 			$this->assertEquals( 300, $result[2] );
 			$this->assertFalse( $result[3] );
 
 			$result = $this->dam->alter_attachment_image_src( false, $id, [ 50, 20 ], false );
-			$this->assertContains( 'w:50/h:20/g:ce/rt:fill', $result[0] );
+			$this->assertStringContainsString( 'w:50/h:20/g:ce/rt:fill', $result[0] );
 			$this->assertEquals( 50, $result[1] );
 			$this->assertEquals( 20, $result[2] );
 			$this->assertEquals( true, $result[3] );
@@ -289,13 +278,13 @@ public function test_alter_attachment_for_js(  ) {
 			$this->assertEquals( self::IMAGE_SIZES['test_landscape']['width'], $altered['sizes']['test_landscape']['width'] );
 			$this->assertEquals( self::IMAGE_SIZES['test_landscape']['height'], $altered['sizes']['test_landscape']['height'] );
 			$this->assertEquals( self::IMAGE_SIZES['test_landscape']['orientation'], $altered['sizes']['test_landscape']['orientation'] );
-			$this->assertContains( 'w:200/h:100/g:ce/rt:fill', $altered['sizes']['test_landscape']['url'] );
+			$this->assertStringContainsString( 'w:200/h:100/g:ce/rt:fill', $altered['sizes']['test_landscape']['url'] );
 
 			$this->assertArrayHasKey( 'test_portrait', $altered['sizes'] );
 			$this->assertEquals( self::IMAGE_SIZES['test_portrait']['width'], $altered['sizes']['test_portrait']['width'] );
 			$this->assertEquals( self::IMAGE_SIZES['test_portrait']['height'], $altered['sizes']['test_portrait']['height'] );
 			$this->assertEquals( self::IMAGE_SIZES['test_portrait']['orientation'], $altered['sizes']['test_portrait']['orientation'] );
-			$this->assertContains( 'w:100/h:200/g:ce/rt:fill', $altered['sizes']['test_portrait']['url'] );
+			$this->assertStringContainsString( 'w:100/h:200/g:ce/rt:fill', $altered['sizes']['test_portrait']['url'] );
 		}
 	}
 
@@ -320,20 +309,4 @@ private function get_iframe_args_from_url( $url ) {
 	private function insert_mock_attachments() {
 		$this->inserted_ids = $this->dam->insert_attachments( self::MOCK_ATTACHMENTS );
 	}
-
-	private function add_image_sizes() {
-		foreach ( self::IMAGE_SIZES as $slug => $args ) {
-			add_image_size( $slug, $args['width'], $args['height'], $args['crop'] );
-		}
-	}
-
-	private function remove_image_sizes() {
-		foreach ( self::IMAGE_SIZES as $slug => $args ) {
-			remove_image_size( $slug );
-		}
-	}
-
-	public function tear_down() {
-		$this->remove_image_sizes();
-	}
 }