feat: allow mails to be intercepted using events #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikk150
reviewed
Feb 24, 2025
|
I'm going to try this tomorrow, today is national holiday where I live.. |
SamMousa
commented
Feb 24, 2025
Collaborator
Author
|
Todo: write tests for this configuration. |
|
It works! I think it is way simpler solution, and does not require mocking mailer at all which is a good thing. Only thing people have to keep in mind now is that using these new methods, emails could be actually sent out if you do not implement dummy mailer I had to slightly change my mailer, but it was simply broken and I didn't know it |
mikk150
reviewed
Feb 26, 2025
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative for #117.
@mikk150 could you give this a go?
The idea behind this PR is to alternatively allow you to use the
beforeSendorafterSendevents for logging mails.This should work by just setting a configuration in the module config; set
mailMethodtobeforein the codeption config.Let me know what you think; thanks for your contribution in #117 and bringing this feature to Codeception.