sendDELETE with request body

[AndreasBilke]

I tried to update module-rest from 1.2.7 to 1.3.0 and my tests with sendDELETE are failing because codeception no longer sends the $params as request body but as query parameters.

Is there a way to restore the old behaviour? Request bodys are allowed in HTTP DELETE and therefore should be supported by codeception too.

[Insolita]

RFC 7231 specifies that a DELETE request may include a body. Please, reverted these change or make them configurable

[Naktibalda]

I will revert it.

[Naktibalda]

@SamMousa This is the opposite of what was said in #44
Please discuss it :)

[Insolita]

@Naktibalda - We use api by jsonApi spec,

https://jsonapi.org/format/#crud-updating-to-many-relationships

Disallowing to sendDelete with body break test cases without alternatives.

[Insolita]

@SamMousa
May be an additional method sendDeleteWithQueryString would be a suitable compromise

[SamMousa]

I propose instead having 2 params on the send delete method, one for body one for query string. If possible we should not break existing clients (again)

[SamMousa]

Ah wait, the issue was from 2018 but the fix was recent. Then I'm fine with reverting it and leaving it as is.

[SamMousa]

As evidenced few others ran into issues, so no need to make it harder than needed.

[Naktibalda]

Both linked pull requests must be merged and released:
Codeception/lib-innerbrowser#38
#56

I will release new versions in a few days.

[Naktibalda]

I released this change as module-rest 1.3.1 and lib-innerbrowser 1.5.0