Skip to content

Fix compatibility with symfony/dom-crawler < 5.3.0-BETA-1 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Fix compatibility with symfony/dom-crawler < 5.3.0-BETA-1 #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions src/Codeception/Lib/InnerBrowser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,7 +1013,7 @@ private function getFormFromCrawler(Crawler $form): SymfonyForm
$formId = $form->attr('id');
if ($formId !== null) {
$fakeForm = $fakeDom->firstChild;
$topParent = $form->ancestors()->last();
$topParent = $this->getAncestorsFor($form)->last();
$fieldsByFormAttribute = $topParent->filter(
sprintf('input[form=%s],select[form=%s],textarea[form=%s]', $formId, $formId, $formId)
);
Expand Down Expand Up @@ -1044,7 +1044,7 @@ protected function getFormFor(Crawler $node): SymfonyForm
if (strcasecmp($node->first()->getNode(0)->tagName, 'form') === 0) {
$form = $node->first();
} else {
$form = $node->ancestors()->filter('form')->first();
$form = $this->getAncestorsFor($node)->filter('form')->first();
}

if (!$form) {
Expand All @@ -1059,6 +1059,24 @@ protected function getFormFor(Crawler $node): SymfonyForm
return $this->forms[$identifier];
}

/**
* Returns the ancestors of the passed SymfonyCrawler.
*
* symfony/dom-crawler deprecated parents() in favor of ancestors()
* This provides backward compatibility with < 5.3.0-BETA-1
*
* @param SymfonyCrawler $crawler the crawler
* @return SymfonyCrawler the ancestors
*/
private function getAncestorsFor(SymfonyCrawler $crawler): SymfonyCrawler
{
if (method_exists($crawler, 'ancestors')) {
return $crawler->ancestors();
}

return $crawler->parents();
}

/**
* Returns an array of name => value pairs for the passed form.
*
Expand Down