Skip to content

[BUG] : prevent "Uncaught TypeError: explode(): Argument #2 ($string) must be of type string, null given" #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2021
Merged

[BUG] : prevent "Uncaught TypeError: explode(): Argument #2 ($string) must be of type string, null given" #47

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4f3223
fix: prevent "explode" error when responseContentType is null
Fahl-Design Dec 14, 2021
ff0c72b
Update src/Codeception/Lib/InnerBrowser.php
Fahl-Design Dec 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Codeception/Lib/InnerBrowser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public function _failed(TestInterface $test, $fail)
$internalResponse = false;
}

$responseContentType = $internalResponse ? $internalResponse->getHeader('content-type') : '';
$responseContentType = $internalResponse ? $internalResponse->getHeader('content-type') ?? '': '';
[$responseMimeType] = explode(';', $responseContentType);

$extension = $extensions[$responseMimeType] ?? 'html';
Expand Down