Skip to content

fix(SelectDropdown): adding optional zIndex prop #3176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix(SelectDropdown): adding optional zIndex prop #3176

wants to merge 8 commits into from

Conversation

LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented Sep 23, 2025 •
edited
Loading

Overview

Adding an optional zIndex prop to SelectDropdown's menu to address zIndex collisions.

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GM-1307
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Go to SelectDropdown and navigate to the "Menu z-index" canvas
  2. see that the dropdown menu rests on top of the DataList table when given a zIndex (and the one using the default value is behind the table header)
  3. ...
  4. Finish and do a celebratory dance

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 23, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 20918c0

Command Status Duration Result
nx run-many --target=build --all ✅ Succeeded 2s View ↗
nx run-many --target=verify --parallel=3 --all ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-02 13:51:56 UTC

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://68de84671b59cf83f90c57a7--gamut-preview.netlify.app

Deploy Logs

@LinKCoding LinKCoding marked this pull request as ready for review October 2, 2025 14:00
@LinKCoding LinKCoding requested a review from a team as a code owner October 2, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemhiller jakemhiller Awaiting requested review from jakemhiller jakemhiller is a code owner automatically assigned from Codecademy/gamut

@dreamwasp dreamwasp Awaiting requested review from dreamwasp dreamwasp is a code owner automatically assigned from Codecademy/gamut

@aresnik11 aresnik11 Awaiting requested review from aresnik11

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LinKCoding @codecademydev