Skip to content

Conversation

@dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Sep 3, 2025

Overview

Updates Checkbox + Radio colors to match Figma tokens

PR Checklist

  • Related to designs: Form Inputs
  • Related to JIRA ticket: [gm-1275 + gm-1276]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to Checkbox story
  2. See it looks the same
  3. Inspect and see that unchecked checkbox is now using border-primary
  4. Go to Radio story
  5. See it looks the same
  6. Inspect and see that that Radio is now using border-primary

Bonus points

  • Check out this PR and see the Radio + Checkbox now look good in the Percipio theme in this PR. You can check it out using the theme switcher at the top of the page!

PR Links and Envs

Its really not a big deal I promise

@nx-cloud
Copy link

nx-cloud bot commented Sep 3, 2025

View your CI Pipeline Execution ↗ for commit 8e811f3

Command Status Duration Result
nx run-many --target=verify --parallel=3 --all ✅ Succeeded <1s View ↗
nx run-many --target=build --all ✅ Succeeded 18s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-03 14:20:42 UTC

@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://68b84f4b00cc8672b0dadff5--gamut-preview.netlify.app

Deploy Logs

@dreamwasp dreamwasp marked this pull request as ready for review September 3, 2025 17:30
@dreamwasp dreamwasp requested a review from a team as a code owner September 3, 2025 17:30
Copy link
Contributor

@LinKCoding LinKCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkbox and Radio components look good to me!

@dreamwasp dreamwasp added the Ship It :shipit: Automerge this PR when possible label Sep 5, 2025
@codecademydev codecademydev merged commit 3df9da8 into main Sep 5, 2025
30 of 32 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Sep 5, 2025
@codecademydev codecademydev deleted the cass-gm-1275 branch September 5, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants